Dashboard

r5267
nil values will not be checked to see if it a default setting

ok, first off - note to self: add comments next time so when you revist the code in 12mths time you know what the hell you were thinking of at the time (I'm pretty sure I've written that note before)

When I first did this I used re-list times as a minimum getting something like this:

if not success then
	return times
end

local calcTimes = failed / ( success > 0 and success or 1 )
return calcTimes < times and times or calcTimes

But i noticed that a lot of my auctions were selling at a better rate than that (i had debug print statements peppered in there too). I also noticed that it was telling me to disenchant items that i knew were selling better than the mats (I then re-wrote a large chunk of disenchant, but that should be the subject of a different patch when i get around to doing it )

This led me to change to using re-list as an expected number of re-posts, getting the following (comments added this time):

--nil check not needed as it's taken care of by the math below
--if not success then
--	return times
--end

--use expected # if not enough data for fails. Even if auction is always
--successful, the returned value very quickly starts to approach zero (much
--better than it was before)
if ( failed < times ) then
	failed = times
end

--always assume that there will be a successful auction at the end of the fails
--(ie. +1). To be more accurate you would only add one if the last auction
--failed, adding one when it was a success skews the value slightly towards
--zero. However, I like to think of this as encouraging me to auction the same
--item again based on my recent success, and it keeps things simple :)
return failed / ( success + 1 )

And with this change and the one to disenchant, i went off and made a nice tidy profit flipping items that i knew my competition was being told to disenchant, instead of adding comments and updating the tooltip text properly

Your right, i actually re-wrote the formula just before i posted it, forgetting that successful auctions refunded the deposit (i also changed 'relisted' to 'listed' in the tooltip text at the same time)

My original formula was a little bit simpler.

if ( failed < times ) then
failed = times
end

return failed / ( success + 1 )

I'll have to take another look at it after i've had some sleep

wildcard:

Moving Relist Times calculation to a function is a good idea.
It needs to be a lib function though - i.e. lib.GetRelistTimes(hyperlink) - so that modules using AUIS's plugin features can access it. (Note: making it a lib usually means adding at least some parameter checking at the start.)

I'll have to think about the formula though.
Relist Times is the expected number of times you'll have to relist (and lose your deposit) before you manage to sell:
Logically this would simply be failures/successes (with the usual caveats for low numbers of samples and divide-by-zero, of course).
However any tweaking of the formula would be easy enough once it's moved into a dedicated function, as above.

wildcard_25 Nice patches. Would you like to join the team. That way you can have a proper svn account?

r5266
Continues BCNT-316 Updates Database to 3.03
changes schedule task to fix AddOns\BeanCounter\BeanCounterTidyUp.lua line 56:
rewrites config parser to be more useful with new layout.
Updates Integrity check function to fix invalid top level tables.

Just so you know, you are missing some of the newer treasure nodes,
These are the treasure nodeids I have in my personal branch version (for comparison):
[2560] = "TREASURE_BOTTLE", – Half-Buried Bottle
[2744] = "TREASURE_CLAM", – Giant Clam
[2843] = "TREASURE_CHEST", – Battered Chest
[2844] = "TREASURE_CHEST", – Tattered Chest
[2845] = "TREASURE_CHEST", – Tattered Chest
[2846] = "TREASURE_CHEST", – Tattered Chest
[2847] = "TREASURE_CHEST", – Tattered Chest
[2849] = "TREASURE_CHEST", – Battered Chest
[2850] = "TREASURE_CHEST", – Solid Chest
[2852] = "TREASURE_CHEST", – Solid Chest
[2855] = "TREASURE_CHEST", – Solid Chest
[2857] = "TREASURE_CHEST", – Solid Chest
[2883] = "TREASURE_PUMPKIN", – Ripe Pumpkin
[2884] = "TREASURE_CLAM", – Clam
[3658] = "TREASURE_BARREL", – Water Barrel
[3659] = "TREASURE_BARREL", – Barrel of Melon Juice
[3660] = "TREASURE_CRATE", – Armor Crate
[3661] = "TREASURE_CRATE", – Weapon Crate
[3662] = "TREASURE_CRATE", – Food Crate
[3689] = "TREASURE_CRATE", – Weapon Crate
[3690] = "TREASURE_CRATE", – Food Crate
[3691] = "TREASURE_CRATE", – Food Crate
[3693] = "TREASURE_CRATE", – Food Crate
[3694] = "TREASURE_CRATE", – Food Crate
[3695] = "TREASURE_CRATE", – Food Crate
[3702] = "TREASURE_CRATE", – Armor Crate
[3703] = "TREASURE_CRATE", – Armor Crate
[3704] = "TREASURE_CRATE", – Weapon Crate
[3705] = "TREASURE_BARREL", – Barrel of Milk
[3706] = "TREASURE_BARREL", – Barrel of Sweet Nectar
[3707] = "TREASURE_CRATE", – Food Crate
[3714] = "TREASURE_FOOTLOCKER", – Alliance Strongbox
[3715] = "TREASURE_CHEST", – Tattered Chest
[19017] = "TREASURE_CLAM", – Giant Clam
[19018] = "TREASURE_CLAM", – Giant Clam
[19019] = "TREASURE_CRATE", – Box of Assorted Parts
[19020] = "TREASURE_CRATE", – Box of Assorted Parts
[28604] = "TREASURE_CRATE", – Scattered Crate
[74447] = "TREASURE_FOOTLOCKER", – Large Iron Bound Chest
[74448] = "TREASURE_CHEST", – Large Solid Chest
[75293] = "TREASURE_CHEST", – Large Battered Chest
[75295] = "TREASURE_FOOTLOCKER", – Large Iron Bound Chest
[75296] = "TREASURE_FOOTLOCKER", – Large Iron Bound Chest
[75297] = "TREASURE_FOOTLOCKER", – Large Iron Bound Chest
[75298] = "TREASURE_CHEST", – Large Solid Chest
[75299] = "TREASURE_CHEST", – Large Solid Chest
[75300] = "TREASURE_CHEST", – Large Solid Chest
[105570] = "TREASURE_FOOTLOCKER", – Alliance Strongbox
[105578] = "TREASURE_CHEST", – Tattered Chest
[123330] = "TREASURE_FOOTLOCKER", – Buccaneer's Strongbox
[123331] = "TREASURE_FOOTLOCKER", – Buccaneer's Strongbox
[123332] = "TREASURE_FOOTLOCKER", – Buccaneer's Strongbox
[123333] = "TREASURE_FOOTLOCKER", – Buccaneer's Strongbox
[131978] = "TREASURE_FOOTLOCKER", – Large Mithril Bound Chest
[131979] = "TREASURE_CHEST", – Large Darkwood Chest
[141931] = "TREASURE_HIPPOGRYPHEGG", – Hippogryph Egg
[142191] = "TREASURE_CRATE", – Horde Supply Crate
[153468] = "TREASURE_FOOTLOCKER", – Large Mithril Bound Chest
[157936] = "TREASURE_UNGOROSOIL", – Un'Goro Dirt Pile
[164658] = "TREASURE_UNGOROCRYST", – Blue Power Crystal
[164659] = "TREASURE_UNGOROCRYST", – Green Power Crystal
[164660] = "TREASURE_UNGOROCRYST", – Red Power Crystal
[164661] = "TREASURE_UNGOROCRYST", – Yellow Power Crystal
[164881] = "TREASURE_NIGHTDRAGON", – Cleansed Night Dragon
[164882] = "TREASURE_SONGFLOWER", – Cleansed Songflower
[164883] = "TREASURE_WHIPPERROOT", – Cleansed Whipper Root
[164884] = "TREASURE_WINDBLOSSOM", – Cleansed Windblossom
[164885] = "TREASURE_NIGHTDRAGON", – Corrupted Night Dragon
[164886] = "TREASURE_SONGFLOWER", – Corrupted Songflower
[164887] = "TREASURE_WINDBLOSSOM", – Corrupted Windblossom
[164888] = "TREASURE_WHIPPERROOT", – Corrupted Whipper Root
[164958] = "TREASURE_BLOODPETALSPROUT", – Bloodpetal Sprout
[174622] = "TREASURE_WHIPPERROOT", – Cleansed Whipper Root
[176213] = "TREASURE_BLOODOFHEROES", – Blood of Heroes
[176582] = "TREASURE_SHELLFISHTRAP", – Shellfish Trap
[177784] = "TREASURE_CLAM", – Giant Softshell Clam
[178244] = "TREASURE_FOOTLOCKER", – Practice Lockbox
[178245] = "TREASURE_FOOTLOCKER", – Practice Lockbox
[178246] = "TREASURE_FOOTLOCKER", – Practice Lockbox
[179486] = "TREASURE_FOOTLOCKER", – Battered Footlocker
[179487] = "TREASURE_FOOTLOCKER", – Waterlogged Footlocker
[179488] = "TREASURE_FOOTLOCKER", – Battered Footlocker
[179489] = "TREASURE_FOOTLOCKER", – Waterlogged Footlocker
[179490] = "TREASURE_FOOTLOCKER", – Battered Footlocker
[179491] = "TREASURE_FOOTLOCKER", – Waterlogged Footlocker
[179492] = "TREASURE_FOOTLOCKER", – Dented Footlocker
[179493] = "TREASURE_FOOTLOCKER", – Mossy Footlocker
[179494] = "TREASURE_FOOTLOCKER", – Dented Footlocker
[179496] = "TREASURE_FOOTLOCKER", – Dented Footlocker
[179497] = "TREASURE_FOOTLOCKER", – Mossy Footlocker
[179498] = "TREASURE_FOOTLOCKER", – Scarlet Footlocker
[181598] = "TREASURE_SILITHYSTGEYSER", – Silithyst Geyser
[181665] = "TREASURE_FOOTLOCKER", – Burial Chest
[181798] = "TREASURE_CHEST", – Fel Iron Chest
[181800] = "TREASURE_CHEST", – Heavy Fel Iron Chest
[181802] = "TREASURE_CHEST", – Adamantite Bound Chest
[181804] = "TREASURE_CHEST", – Felsteel Chest
[182053] = "TREASURE_GLOWCAP", – Glowcap
[182069] = "TREASURE_SPORESAC", – Mature Spore Sac
[182258] = "TREASURE_OSHUGUNCRYSTAL", – Oshu'gun Crystal Fragment
[184740] = "TREASURE_FOOTLOCKER", – Wicker Chest
[184741] = "TREASURE_FOOTLOCKER", – Dented Footlocker
[184793] = "TREASURE_FOOTLOCKER", – Primitive Chest
[184930] = "TREASURE_CHEST", – Solid Fel Iron Chest
[184931] = "TREASURE_FOOTLOCKER", – Bound Fel Iron Chest
[184932] = "TREASURE_FOOTLOCKER", – Bound Fel Iron Chest
[184933] = "TREASURE_CHEST", – Solid Fel Iron Chest
[184934] = "TREASURE_FOOTLOCKER", – Bound Fel Iron Chest
[184935] = "TREASURE_CHEST", – Solid Fel Iron Chest
[184936] = "TREASURE_FOOTLOCKER", – Bound Adamantite Chest
[184937] = "TREASURE_CHEST", – Solid Adamantite Chest
[184938] = "TREASURE_FOOTLOCKER", – Bound Adamantite Chest
[184939] = "TREASURE_CHEST", – Solid Adamantite Chest
[184940] = "TREASURE_FOOTLOCKER", – Bound Adamantite Chest
[184941] = "TREASURE_CHEST", – Solid Adamantite Chest
[185911] = "TREASURE_APEXISSHARD", – Apexis Shard Formation
[185915] = "TREASURE_NETHERWINGEGG", – Netherwing Egg
[187367] = "TREASURE_WINTERFINCLAM", – Winterfin Clam
[191543] = "TREASURE_FOOTLOCKER", – Scarlet Onslaught Trunk
[193997] = "TREASURE_EVERFROSTCHIP", – Everfrost Chip
[202470] = "TREASURE_CHEST", – Battered Chest
[205878] = "TREASURE_CHEST", – Battered Chest
[205879] = "TREASURE_CHEST", – Battered Chest
[205880] = "TREASURE_CHEST", – Battered Chest
[205881] = "TREASURE_CHEST", – Battered Chest
[207472] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207473] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207474] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207475] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207476] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207477] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207478] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207479] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207480] = "TREASURE_CHEST", – Silverbound Treasure Chest
[207484] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207485] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207486] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207487] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207488] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207489] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207492] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207493] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207494] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207495] = "TREASURE_CHEST", – Sturdy Treasure Chest
[207496] = "TREASURE_CHEST", – Dark Iron Treasure Chest
[207497] = "TREASURE_CHEST", – Dark Iron Treasure Chest
[207498] = "TREASURE_CHEST", – Dark Iron Treasure Chest
[207500] = "TREASURE_CHEST", – Dark Iron Treasure Chest
[207507] = "TREASURE_CHEST", – Dark Iron Treasure Chest
[207512] = "TREASURE_CHEST", – Silken Treasure Chest
[207513] = "TREASURE_CHEST", – Silken Treasure Chest
[207517] = "TREASURE_CHEST", – Silken Treasure Chest
[207518] = "TREASURE_CHEST", – Silken Treasure Chest
[207519] = "TREASURE_CHEST", – Silken Treasure Chest
[207520] = "TREASURE_CHEST", – Maplewood Treasure Chest
[207521] = "TREASURE_CHEST", – Maplewood Treasure Chest
[207522] = "TREASURE_CHEST", – Maplewood Treasure Chest
[207523] = "TREASURE_CHEST", – Maplewood Treasure Chest
[207524] = "TREASURE_CHEST", – Maplewood Treasure Chest
[207528] = "TREASURE_CHEST", – Maplewood Treasure Chest
[207529] = "TREASURE_CHEST", – Maplewood Treasure Chest
[207533] = "TREASURE_CHEST", – Runestone Treasure Chest
[207534] = "TREASURE_CHEST", – Runestone Treasure Chest
[207535] = "TREASURE_CHEST", – Runestone Treasure Chest
[207540] = "TREASURE_CHEST", – Runestone Treasure Chest
[207542] = "TREASURE_CHEST", – Runestone Treasure Chest

Generate patch file using unix diff instead of dumb program that replaced leading tabs with spaces