FishEye: history Auctioneer/branches/4.0/enhtooltip/Tooltip.lua

1534 annotated / raw | Diffs: previous, other | Lines: 1718 ( +3, -3 )

Created: 2007-02-26 15:21:57 -0500 (22 months ago) | Author: mentalpower | Changeset: 1534

Copied to: branches/4.0/enhtooltip/Tooltip.lua 1538

Slightly optmized EnhTooltip's breakLink() and gtHookSetText() functions.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1516 annotated / raw | Diffs: previous, other | Lines: 1718 ( +68, -48 )

Created: 2007-02-18 22:09:09 -0500 (22 months ago) | Author: luke1410 | Changeset: 1516

(fixes #1346) Enhanced tooltip should work properly with any addon which sticks their tooltip to the cursor, now.

Refering to http://www.wowwiki.com/API_GameTooltip_SetOwner setting the offsets for x/y don't have any effect when the frame is anchored to the tooltip. Therefore I guess that the SetPoint() function is also not designed to work properly, if the anchor is set to the cursor and should not be used to move the frame.

Before this revision we did not check the case for ANCHOR_CURSOR and tried to move the current tooltip which resulted in this strange bug.

The current solution disables the relocation of the tooltip, if the current tooltip is anchored to the cursor. A better way would have been to code something to set the point, where the mousecursor is anchored, so that the complete tooltip will still be shown on screen. Nevertheless I hope that this fix will do fine for the moment. (a new ticket was opened, to keep this possible enhancement in mind for one of the next releases #1469)

Because quite alot of changes were necessary to properly fix this issue and I only tested the anchor code for a few minutes using CT_BuffMod, I'd appreciate any code reviewing and or further testing to make sure that no other bug made it into the code.

In advance added some more code comments.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1515 annotated / raw | Diffs: previous, other | Lines: 1698 ( +28, -28 )

Created: 2007-02-18 21:41:12 -0500 (22 months ago) | Author: luke1410 | Changeset: 1515

code layout changes

Renamed several local variables in showTooltip() to make the code easier understandable.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1514 annotated / raw | Diffs: previous, other | Lines: 1698 ( +5, -5 )

Created: 2007-02-18 20:20:00 -0500 (22 months ago) | Author: luke1410 | Changeset: 1514

code optimisations

Removed the unused second parameters from getTooltipWidth and getTooltipHeight, since both are quite confusing, as they let u wonder what those functions use this second parameter for.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1513 annotated / raw | Diffs: previous, other | Lines: 1698 ( +2, -2 )

Created: 2007-02-18 20:12:21 -0500 (22 months ago) | Author: luke1410 | Changeset: 1513

fixed two potential issues which might have caused problems with other addons

In changeset 328 two variables were set to global access instead of local access in showTooltip(). To not pollute the global namespace anylonger, both are now set to locals.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1512 annotated / raw | Diffs: previous, other | Lines: 1698 ( +1, -1 )

Created: 2007-02-18 20:09:45 -0500 (22 months ago) | Author: luke1410 | Changeset: 1512

tiny code optimisation

Removed an unnecessary table lookup.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1511 annotated / raw | Diffs: previous, other | Lines: 1698 ( +5, -8 )

Created: 2007-02-18 20:08:26 -0500 (22 months ago) | Author: luke1410 | Changeset: 1511

code optimisations

Removed the second parameter from getRect() which had no effect at all.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1490 annotated / raw | Diffs: previous, other | Lines: 1701 ( +87, -87 )

Created: 2007-02-13 10:11:21 -0500 (22 months ago) | Author: luke1410 | Changeset: 1490

code layout changes

Renamed the local self variable to EnhTTData, so it won't confuse us with the self variable, Blizzard uses, if a function is called in an xml declaration (see changes on WoW 2.0).
In advance we no longer hide blizzards variable by defining a local self variable which allows us access to blizzard functions in tooltip.lua.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1488 annotated / raw | Diffs: previous, other | Lines: 1701 ( +10, -3 )

Created: 2007-02-13 02:03:42 -0500 (22 months ago) | Author: dinesh | Changeset: 1488

Fix bug with duplicating embedded tooltip when shift- or ctrl-clicking a hyperlink after tooltip is already displayed for that item. Also expands enhanced tooltip to work for all hyperlinks, not just chat hyperlinks. (fixes #1306)

When tooltip is already open, both clicking and alt-clicking the hyperlink again will actually close the tooltip, which causes doHyperlink to do nothing. Shift- and ctrl-clicking (which don't affect the tooltip at all) were still calling the doHyperlink code, which caused additional copies of the embedded tooltip data to appear. These two modifier keys are now trapped and returned without doing anything.

Also changes hooked function from ChatFrame_OnHyperlinkShow to SetItemRef, so that all hyperlinks (not just chat frame ones) will be hooked.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1486 annotated / raw | Diffs: previous, other | Lines: 1694 ( +0, -25 )

Created: 2007-02-12 23:16:55 -0500 (22 months ago) | Author: dinesh | Changeset: 1486

Fix embedded tooltip doubling when picking up container frame. Thanks to Goncyn for providing all debugging and completed patch. (fixes #1210)

From Goncyn: "After some debugging, I was able to determine that this happens because of the ContainerFrame_Update hook, which is *not* triggered by a GameTooltip.SetX call, so the tooltip is not cleared before EnhTooltip's hook executes, and existing embedded lines will be doubled."

Testing has confirmed that hooking ContainerFrame_Update appears not to be necessary, as the previous tooltip is not getting cleared.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1342 annotated / raw | Diffs: previous, other | Lines: 1719 ( +33, -10 )

Created: 2007-01-13 11:36:58 -0500 (23 months ago) | Author: luke1410 | Changeset: 1342

(fixes #1295) Stubby/Enhanced Tooltip could report the following error message:
..\AddOns?\EnhTooltip\Tooltip.lua line 835: attempt to index local 'line' (a nil value)
This has been fixed.

The function addSeparator() missed to check if the requested font string line exists. In case it does not, which occures whenever one tries to add a separator after the last line the tooltip, line is nil and will result in an errormessage on the next line.
The code was changed to make sure that a new line is being created for the separator, if it does not exist. Please also read the note on the new function getLine(), which explains a possible case in which the nil bug could still occure.

Additionally changed the code in createNewFontString() to make it more robust against failed function calls to one of blizzards UI functions, which might also cause the nil bug.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1326 annotated / raw | Diffs: previous, other | Lines: 1696 ( +0, -0 )

Created: 2007-01-11 22:25:09 -0500 (23 months ago) | Author: norganna | Changeset: 1326

Remove bandaid addon, Fix up eol-style and add URL to keyword expansion list across a majority of files in the repository.

Properties

svn:eol-style = native
svn:keywords = URL Author Date Rev Id

1285 annotated / raw | Diffs: previous, other | Lines: 1696 ( +1, -1 )

Created: 2007-01-01 23:38:50 -0500 (2 years ago) | Author: tml | Changeset: 1285

fixed all references to the "GLP" to be "GPL" instead.

Properties