•  
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Performing removal of current trunk to branches/4.90
Performing removal of current trunk to branches/4.90
  1. … 379 more files in changeset.
Standardized the SVN:Keywords property to read "Author Date Id Revision URL". Also standardized the boilerplates so that they have Revision, URL and Version fields. Additionally standardized the Versi…
Standardized the SVN:Keywords property to read "Author Date Id Revision URL". Also standardized the boilerplates so that they have Revision, URL and Version fields. Additionally standardized the Version field to read "<%version%> (<%codename%>)"
  1. … 123 more files in changeset.
"foo, bar, baz = select(1, ...)" is functionally the same as "foo, bar, baz = ...". The latter also has the advantage of being faster.
"foo, bar, baz = select(1, ...)" is functionally the same as "foo, bar, baz = ...". The latter also has the advantage of being faster.
  1. … 5 more files in changeset.
Add table recycling and improve per-frame memory efficiency (since we have to run once per frame these days, it's quite important) We're down to about 30k/s use when mousing over a container or invent…
Add table recycling and improve per-frame memory efficiency (since we have to run once per frame these days, it's quite important) We're down to about 30k/s use when mousing over a container or inventory slot.
Revert inadvertant changes to the tooltip text size
Revert inadvertant changes to the tooltip text size
Conversion of BtmScan and Enchantrix to nConfigator.
Conversion of BtmScan and Enchantrix to nConfigator.

  1. … 14 more files in changeset.
Set bulk svn:eol-style properties to native
Set bulk svn:eol-style properties to native
  1. … 50 more files in changeset.
make EnhTooltip trunk work with older versions of addons that expected the DebugPrint routine in EnhTT to be available
make EnhTooltip trunk work with older versions of addons that expected the DebugPrint routine in EnhTT to be available

Make a minor change to the EnhTooltip functions so that additional data can be passed along with the Tooltip hook, depending on the context it's called from (in this case, we're using it to send addit…
Make a minor change to the EnhTooltip functions so that additional data can be passed along with the Tooltip hook, depending on the context it's called from (in this case, we're using it to send additional auction information)
(fixes #1640, #1641) Enhanced tooltip will no longer cause a drastical fps dropdown while mousing over items in the mailbox. This also fixes the issue that enhTT won't be displayed for all new TBC ite…
(fixes #1640, #1641) Enhanced tooltip will no longer cause a drastical fps dropdown while mousing over items in the mailbox. This also fixes the issue that enhTT won't be displayed for all new TBC items there.

The implementation for the SetInboxItem() hook iterated over all items (1 to 30000) to get the itemLink. Depending on what the real itemID was, that could last quite a while. While this has been present as of the first implementation in r855, it has not had that much of an impact over the performance, as most items had ids lower than 10000. With the new TBC items having IDs > 20000, that's now recognized as an annoying behavior by most users. A side effect of the old implementation was that items with an id > 30000 would not be recognized resulting in no enhanced tooltips being displayed.

The changed function now used GetInboxItemLink() rather than trying to iterate over all items.

  1. … 2 more files in changeset.
Removing debugging call
Removing debugging call
Convert EnhTooltip's Tooltip.lua to fully public/private functions in line with new design methodology
Convert EnhTooltip's Tooltip.lua to fully public/private functions in line with new design methodology
(fixes #1619) The game tooltip will no longer display text outside of its boundaries, which happened before under some special circumstances.…
(fixes #1619) The game tooltip will no longer display text outside of its boundaries, which happened before under some special circumstances.

When a new line is added to the tooltip the tooltip's width/height is not automatically adjusted. A call to Gametooltip:Show() is needed to update the borders so that the just added tooltip text appears inside the tooltip. In case a tooltip only contains embedded data, we do not explicitly call GameTooltip:Show() again, which ends up with the text appearing outside the frame. The side effect of this "workaround" is that we are now calling GameTooltip:Show() twice, which costs us some performance and potentially might cause problems with addons not handling subsequent calls to :Show() in a compatible manner. Another way of fixing this could be to add the lines before the original Show() function is called, but this requires a lot of refactoring of the EnhTT call, since showTooltip() is called in several positions. With the upcoming rewrite of EnhTT it's not worth the effort, I doubt. A second solution might be to calculate the necessary width/height after we add the embedded text, which might be more correct than the current workaround, but on the other side requires us to keep these calculations up to date with every change Blizzard makes upon setting the Gametooltip width. Therefore the current solution is assumed to be the best possible one.

  1. … 2 more files in changeset.
(fixes #1617) EnhTT will no longer display incorrect tooltip information which might have happened under very special circumstances before.…
(fixes #1617) EnhTT will no longer display incorrect tooltip information which might have happened under very special circumstances before.

The generation of the item signature has been altered and a separator has been added in between itemString, count and price. Therefore valid calls to tooltipCall() can now no longer result in the same item signature for different items.

  1. … 2 more files in changeset.
(fixes #1615) Mousing over some items will no longer raise a nil error. It is now also possible to call tooltipCall() without specifying an item count, quality and price.…
(fixes #1615) Mousing over some items will no longer raise a nil error. It is now also possible to call tooltipCall() without specifying an item count, quality and price.

This is the proper fix for the #1615 issue. tooltipCall()'s parameters: quality, count and price are now optional ones and will default to -1, 1 and 0. This centralisation of the code allowed some calls to be altered (since they passed the default values, themselves).

  1. … 1 more file in changeset.
Update toc versions to 20100
Update toc versions to 20100
  1. … 13 more files in changeset.
void…
void

Fixes another case which caused the tooltip becoming too wide (see #1443). The problem was that under some circumstances Blizzard tooltip was not updated before showTooltip() was called. Therefore Blizzard tooltip was still set to the tooltip's width of the previous tooltip and therefore we worked with the incorrect assumption that Blizzard's tooltip was wider than our own one.

EnhTT will now call currentTooltip:Show() before getting the tooltip's width.

In addition the unnecessary call to currentTooltip:Show() after embedRender() was removed, too, which increases the performance if all EnhTT information will be embedded in the currentTooltip.

  1. … 2 more files in changeset.
(fixes #1520) The tooltip will no longer get too wide, even if it's not necessary.…
(fixes #1520) The tooltip will no longer get too wide, even if it's not necessary.

A bug introduced in r1089 was fixed in getTooltipWidth(). lineCount was always nil and so the getglobalIterator() always returned all lines instead of just those, used for the current tooltip.

If one of the previous tooltips had more lines than the current one, and one of its lines was longer than the lines for the current tooltip, the function returned an incorrect width, leading to the current tooltip becoming too wide. This can happen, because line objects are not removed, once created.

  1. … 2 more files in changeset.
void…
void

fixes a bug introduced in r1765: According to wowwiki, setOwner supports nil as the frame's owner which is the same as using UIParent. Though it does not look like Blizzard uses it in its own functions (instead they use UIParent), it can (and is) be(ing) used by 3rd party developers. This has been taken care of now. Therefore #1512 is now properly fixed and should work correctly (including proper alignment - see #1519).

  1. … 2 more files in changeset.
(fixes #1519) EnhTT will no longer move the tooltip frame, if it's not absolutely necessary.…
(fixes #1519) EnhTT will no longer move the tooltip frame, if it's not absolutely necessary.

Reverted changes made to tooltip.lua starting r1606, since the correct behaviour should be to check for currentTooltipOwner == UIParent. I double checked the current code against the bagnon-usage, and can't reproduce the bug reported in #1512). So either bagnon had a bug, which has been fixed meanwhile, the old check (:GetName() == "UIParent") does not equal the new one (Tooltip == UIParent) or the bug was not caused by that part of the code at all.

  1. … 2 more files in changeset.
(fixes #1557) EnhTT.CheckPopup() finally works as intended.…
(fixes #1557) EnhTT.CheckPopup() finally works as intended.

In r422 a bug was introduced which called the local function of checkPopup() rather than the global, hooked one. Therefore EnhTT always displayed its tooltip, even if a 3rd party addon hooked CheckPopup() trying to disable tooltips, while showing its own popup window.

Nevertheless even in r421 and before CheckPopup() didn't work as intended, either, since the required popup-array was never populated.

  1. … 2 more files in changeset.
Huge debug log revamp…
Huge debug log revamp

Ported debug handling to the new DebugLib for all addons. Therefore each addon will now use nLog, if installed, to generate log messages. It's no longer necessary to change debug switches in each file and create a new chat channel for debugging.

Additionally some minor mistakes were fixed as well as some indention changes. Probably something else, too, I just forgot right now.

  1. … 51 more files in changeset.
updated tocs to properly load nLog…
updated tocs to properly load nLog

Though because of nlogs folder name, nLog already should have been loaded before each other addon, adding it to the optional dependency list, is the correct way. This has been changed so that nLog is properly loaded before DebugLib as suggested in DebugLibs manual.

  1. … 10 more files in changeset.
void…
void

Fixed proper loading of DebugLib. Pathdelimiters in the tocs must use \. The old / syntax caused the debuglib not to be loaded at all. Also rearanged the loading order in Auctioneer.toc, to properly handle the upcoming changes to the debug system.

  1. … 8 more files in changeset.
removed deprecated functions: lineSize_Small() and lineSize_Large()…
removed deprecated functions: lineSize_Small() and lineSize_Large()

both functions removed (see r1730)

void…
void

enabled DebugLib embedded library by adding the new lua file to the tocs

  1. … 2 more files in changeset.
void…
void

added DebugLib embedded library

  1. … 2 more files in changeset.
reverted inapropriate code optimisation…
reverted inapropriate code optimisation

once again using proper tail call - reverted r1668

code cleanup…
code cleanup

removed functionality which belongs to auctioneer and not to enhTT (see #1526)

code optimisation…
code optimisation

removed unnecessary return value, which was always nil