•  
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Performing removal of current trunk to branches/4.90
Performing removal of current trunk to branches/4.90
  1. … 381 more files in changeset.
Standardized the SVN:Keywords property to read "Author Date Id Revision URL". Also standardized the boilerplates so that they have Revision, URL and Version fields. Additionally standardized the Versi…
Standardized the SVN:Keywords property to read "Author Date Id Revision URL". Also standardized the boilerplates so that they have Revision, URL and Version fields. Additionally standardized the Version field to read "<%version%> (<%codename%>)"
  1. … 125 more files in changeset.
"foo, bar, baz = select(1, ...)" is functionally the same as "foo, bar, baz = ...". The latter also has the advantage of being faster.
"foo, bar, baz = select(1, ...)" is functionally the same as "foo, bar, baz = ...". The latter also has the advantage of being faster.
  1. … 5 more files in changeset.
Set bulk svn:eol-style properties to native
Set bulk svn:eol-style properties to native
  1. … 50 more files in changeset.
Make stubby never unregister its ADDON_LOADED hook via the UnregisterEventHook() call, since it is needed for the RegisterAddOnHook() functions
Make stubby never unregister its ADDON_LOADED hook via the UnregisterEventHook() call, since it is needed for the RegisterAddOnHook() functions
  1. … 2 more files in changeset.
void…
void

merged r1883 into the trunk

Update toc versions to 20100
Update toc versions to 20100
  1. … 13 more files in changeset.
void…
void

ported #1863 to 4.2 and updated the comments

  1. … 1 more file in changeset.
solve a subtle bug in stubby that prevented the auctioneer UI from loading if enchantrix forced auctioneer to load…
solve a subtle bug in stubby that prevented the auctioneer UI from loading if enchantrix forced auctioneer to load

There is a little detail/problem with the # operator in Lua that means you can have a table with items in it, but # will return 0. Either # is intended for arrays and not tables, or the language authors missed something important.

Minor enhancement to wipe a table once it has 0 entries in it
Minor enhancement to wipe a table once it has 0 entries in it

Huge debug log revamp…
Huge debug log revamp

Ported debug handling to the new DebugLib for all addons. Therefore each addon will now use nLog, if installed, to generate log messages. It's no longer necessary to change debug switches in each file and create a new chat channel for debugging.

Additionally some minor mistakes were fixed as well as some indention changes. Probably something else, too, I just forgot right now.

  1. … 51 more files in changeset.
updated tocs to properly load nLog…
updated tocs to properly load nLog

Though because of nlogs folder name, nLog already should have been loaded before each other addon, adding it to the optional dependency list, is the correct way. This has been changed so that nLog is properly loaded before DebugLib as suggested in DebugLibs manual.

  1. … 10 more files in changeset.
void…
void

Fixed proper loading of DebugLib. Pathdelimiters in the tocs must use \. The old / syntax caused the debuglib not to be loaded at all. Also rearanged the loading order in Auctioneer.toc, to properly handle the upcoming changes to the debug system.

  1. … 8 more files in changeset.
void…
void

enabled DebugLib embedded library by adding the new lua file to the tocs

  1. … 2 more files in changeset.
void…
void

added DebugLib embedded library

  1. … 2 more files in changeset.
Corrected the improper use of "it's" in our GPL boilerplate.
Corrected the improper use of "it's" in our GPL boilerplate.
  1. … 33 more files in changeset.
Making new 5.0 trunk active
Making new 5.0 trunk active
  1. … 159 more files in changeset.
Archiving current trunk
Archiving current trunk
  1. … 394 more files in changeset.
Reverted some unfinished code that was accidentally committed.
Reverted some unfinished code that was accidentally committed.
Changed all the version strings to "4.1.DEV". They now all match too :).
Changed all the version strings to "4.1.DEV". They now all match too :).
  1. … 9 more files in changeset.
void…
void

Adjusted the handling of defaults for debugPrint. Instead of defaulting it to "Error", it's now defaulting to "Debug" which makes it quite easier to properly use the function in local debugging sessions.

Also changed the way "priority" is being set to its default value. If "type" is set to one of the strings specified in nLog.levels, the appropriate level is used. That way you simply specify debugPrint("Some error message", [errorCode], "Error") instead of having to add a local counterpart for N_ERROR or check if nLog is present before calling debugPrint("Some error message", [errorCode], "Error", N_ERROR) to make sure that N_ERROR won't throw a nil error, if nLog is not enabled/installed.

Check the remarks in the function description for a more detailed explanation of which default values are used.

  1. … 1 more file in changeset.
void…
void

Fixed the code description about debugPrint to reflect the latest changes and to clarify some things.

void…
void

Changed the default value for debugPritn from N_WARNING to the new N_ERROR level.

void…
void

Revamped the error handling code. Instead of setting a local variable which is common in C-like coding, the functions will return directly the error code/message tailed to their normal return values.

Therefore several functions were removed which are nolonger needed and a new function: debugPrint() was added.

This function can be used as all other debugPrint() functions in the other addons. In advance it allows the specification of an errorcode and adjust the type and priority of the error message.

void…
void

Missed to declare unhookFrom as a local function. Therefore it could be called by any addon and poluted the global namespace. This has been fixed.

void…
void

Changed indention, some comments and the way tableRemoveNilSafe() removes the temporary table to work properly even if any other function uses the tempTable variable

Stubby's tableRemoveNilSafe() function will now re-use its temporary table so that less garbage is created with its use.…
Stubby's tableRemoveNilSafe() function will now re-use its temporary table so that less garbage is created with its use.

Also fixed some funky indenting and trailing whitespace.

void…
void

Fixed a minor bug in the new tableRemoveNilSafe(). The function did not remove the element at [0] as expected. Also rewrote part of the documentation to be a bit more precise.

A bug in stubby was fixed which could shift the return parameters of a hooked function and therefore cause other addons as well as some Auctioneer addons not to work as designed.…
A bug in stubby was fixed which could shift the return parameters of a hooked function and therefore cause other addons as well as some Auctioneer addons not to work as designed.

This also fixes at least some, if not all of the symptoms reported in #1277.

Some Blizzard functions (in the case of #1277 it was GetInboxText() are designed to return nil values in between other return values (in the case of GetInboxText() it returned nil, "STATIONERYTEST", nil).

Stubby.hookCall() is designed to create a table, containing these return values, resulting in a table with holes. table.remove() was used to trim the first value from this created table to remove the pcall result code. Unfortunately table.remove() does not work with tables containing these holes as expected and in this case did not move the index of STATIONERYTEST. This resulted in the unpack() function unpacking and returning STATIONERYTEST as the third, instead of the second parameter.

I'm not absolutely sure what other symptoms are caused by this bug, but I doubt that the mailbox issue is the only one. Nevertheless, since there are no major tickets opened, I did not investigate, if that might have fixed any other tickets, as well.

improved error handling in Stubby…
improved error handling in Stubby

Added error handling for registerFunctionHook and hookInto and added some documentation for these functions.