•  
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fixes a tiny bug in nLog, which resulted in incorrectly concatenated messages…
fixes a tiny bug in nLog, which resulted in incorrectly concatenated messages

in format() we were checking if the last character in the current output was two spaces instead of one single space Therefore format() always added another space before each string

  1. … 2 more files in changeset.
Update InfPrices, InfQuest and BtmPrices data
Update InfPrices, InfQuest and BtmPrices data
    • -1602
    • +2842
    ./btmscan/BtmPrices.lua
    • -9818
    • +9299
    ./informant/Data/InfQuests.lua
    • -4024
    • +4300
    ./informant/Data/InfPrices.lua
  1. … 6 more files in changeset.
(fixes #1640, #1641) Enhanced tooltip will no longer cause a drastical fps dropdown while mousing over items in the mailbox. This also fixes the issue that enhTT won't be displayed for all new TBC ite…
(fixes #1640, #1641) Enhanced tooltip will no longer cause a drastical fps dropdown while mousing over items in the mailbox. This also fixes the issue that enhTT won't be displayed for all new TBC items there.

The implementation for the SetInboxItem() hook iterated over all items (1 to 30000) to get the itemLink. Depending on what the real itemID was, that could last quite a while. While this has been present as of the first implementation in r855, it has not had that much of an impact over the performance, as most items had ids lower than 10000. With the new TBC items having IDs > 20000, that's now recognized as an annoying behavior by most users. A side effect of the old implementation was that items with an id > 30000 would not be recognized resulting in no enhanced tooltips being displayed.

The changed function now used GetInboxItemLink() rather than trying to iterate over all items.

  1. … 2 more files in changeset.
Make stubby never unregister its ADDON_LOADED hook via the UnregisterEventHook() call, since it is needed for the RegisterAddOnHook() functions
Make stubby never unregister its ADDON_LOADED hook via the UnregisterEventHook() call, since it is needed for the RegisterAddOnHook() functions
  1. … 2 more files in changeset.
(fixes #1625 and #1546)All localisation and data files have been updated.
(fixes #1625 and #1546)All localisation and data files have been updated.
    • -47395
    • +49191
    ./btmscan/BtmPrices.lua
    • -4070
    • +4570
    ./informant/Data/InfPrices.lua
  1. … 7 more files in changeset.
(fixes #1619) The game tooltip will no longer display text outside of its boundaries, which happened before under some special circumstances.…
(fixes #1619) The game tooltip will no longer display text outside of its boundaries, which happened before under some special circumstances.

When a new line is added to the tooltip the tooltip's width/height is not automatically adjusted. A call to Gametooltip:Show() is needed to update the borders so that the just added tooltip text appears inside the tooltip. In case a tooltip only contains embedded data, we do not explicitly call GameTooltip:Show() again, which ends up with the text appearing outside the frame. The side effect of this "workaround" is that we are now calling GameTooltip:Show() twice, which costs us some performance and potentially might cause problems with addons not handling subsequent calls to :Show() in a compatible manner. Another way of fixing this could be to add the lines before the original Show() function is called, but this requires a lot of refactoring of the EnhTT call, since showTooltip() is called in several positions. With the upcoming rewrite of EnhTT it's not worth the effort, I doubt. A second solution might be to calculate the necessary width/height after we add the embedded text, which might be more correct than the current workaround, but on the other side requires us to keep these calculations up to date with every change Blizzard makes upon setting the Gametooltip width. Therefore the current solution is assumed to be the best possible one.

  1. … 2 more files in changeset.
(fixes #1617) EnhTT will no longer display incorrect tooltip information which might have happened under very special circumstances before.…
(fixes #1617) EnhTT will no longer display incorrect tooltip information which might have happened under very special circumstances before.

The generation of the item signature has been altered and a separator has been added in between itemString, count and price. Therefore valid calls to tooltipCall() can now no longer result in the same item signature for different items.

  1. … 2 more files in changeset.
void…
void

Fixes another case which caused the tooltip becoming too wide (see #1443). The problem was that under some circumstances Blizzard tooltip was not updated before showTooltip() was called. Therefore Blizzard tooltip was still set to the tooltip's width of the previous tooltip and therefore we worked with the incorrect assumption that Blizzard's tooltip was wider than our own one.

EnhTT will now call currentTooltip:Show() before getting the tooltip's width.

In addition the unnecessary call to currentTooltip:Show() after embedRender() was removed, too, which increases the performance if all EnhTT information will be embedded in the currentTooltip.

  1. … 2 more files in changeset.
(fixes #1520) The tooltip will no longer get too wide, even if it's not necessary.…
(fixes #1520) The tooltip will no longer get too wide, even if it's not necessary.

A bug introduced in r1089 was fixed in getTooltipWidth(). lineCount was always nil and so the getglobalIterator() always returned all lines instead of just those, used for the current tooltip.

If one of the previous tooltips had more lines than the current one, and one of its lines was longer than the lines for the current tooltip, the function returned an incorrect width, leading to the current tooltip becoming too wide. This can happen, because line objects are not removed, once created.

  1. … 2 more files in changeset.
void…
void

fixes a bug introduced in r1765: According to wowwiki, setOwner supports nil as the frame's owner which is the same as using UIParent. Though it does not look like Blizzard uses it in its own functions (instead they use UIParent), it can (and is) be(ing) used by 3rd party developers. This has been taken care of now. Therefore #1512 is now properly fixed and should work correctly (including proper alignment - see #1519).

  1. … 2 more files in changeset.
(fixes #1519) EnhTT will no longer move the tooltip frame, if it's not absolutely necessary.…
(fixes #1519) EnhTT will no longer move the tooltip frame, if it's not absolutely necessary.

Reverted changes made to tooltip.lua starting r1606, since the correct behaviour should be to check for currentTooltipOwner == UIParent. I double checked the current code against the bagnon-usage, and can't reproduce the bug reported in #1512). So either bagnon had a bug, which has been fixed meanwhile, the old check (:GetName() == "UIParent") does not equal the new one (Tooltip == UIParent) or the bug was not caused by that part of the code at all.

  1. … 2 more files in changeset.
Fixes invalid item information being displayed/used. This should fix quite a lot of reported bugs in 4.0.1. For instance this fixes #1558.…
Fixes invalid item information being displayed/used. This should fix quite a lot of reported bugs in 4.0.1. For instance this fixes #1558.

The cache function introduced in r1669 in getItem() did not correctly differentiate between cached calls and non-cached calls. If a the function was called by in uncached mode, and the next call to this function was issued for the same item but in cached mode, the function returned an empty table instead of the proper item information.

Another scenario was that the function could return data for older items. This was caused by the same bug, but caused other symptoms for users.

  1. … 2 more files in changeset.
(fixes #1557) EnhTT.CheckPopup() finally works as intended.…
(fixes #1557) EnhTT.CheckPopup() finally works as intended.

In r422 a bug was introduced which called the local function of checkPopup() rather than the global, hooked one. Therefore EnhTT always displayed its tooltip, even if a 3rd party addon hooked CheckPopup() trying to disable tooltips, while showing its own popup window.

Nevertheless even in r421 and before CheckPopup() didn't work as intended, either, since the required popup-array was never populated.

  1. … 2 more files in changeset.
Huge debug log revamp…
Huge debug log revamp

Ported debug handling to the new DebugLib for all addons. Therefore each addon will now use nLog, if installed, to generate log messages. It's no longer necessary to change debug switches in each file and create a new chat channel for debugging.

Additionally some minor mistakes were fixed as well as some indention changes. Probably something else, too, I just forgot right now.

  1. … 51 more files in changeset.
updated all string files…
updated all string files

this completely closes #1523 and readies 4.0.1 to be released

    • -415
    • +390
    ./beancounter/BeanCounterStrings.lua
    • -1730
    • +1663
    ./informant/InfStrings.lua
  1. … 3 more files in changeset.
tiny code layout changes and performance increase…
tiny code layout changes and performance increase

The check (lineCount == 0) and (headerCount == 0) in showTooltip() was always true, since we check if EnhancedTooltip.hasData is true, before (which itself is only true if lineCount and/or headerCount is > 0). Therefore this section was never entered as of r135 (did not check any previous revisions, since r135 was the revision when EnhTT became its separate addon).

In addition added code comment and improved code layout.

  1. … 1 more file in changeset.
tiny performance improvemnt…
tiny performance improvemnt

Removed a call to GameTooltip:Show() which seems to be no longer necessary.

  1. … 1 more file in changeset.
reverted changes made to clear a table in r1628 plus a tiny code optimisation…
reverted changes made to clear a table in r1628 plus a tiny code optimisation

After MP mentioning that the change to how the embedLines table is cleared might increase memory consumption (since old table entries won't be reused), the change in r1628 was reverted. Also removed an unnecessary variable in embedRender.

  1. … 1 more file in changeset.
code layout improvements…
code layout improvements

Added a couple of comments and improved usage of whitespaces.

  1. … 1 more file in changeset.
code layout changes…
code layout changes

Renamed embedLines.x.line to embedLines.x.text since that's more apropriate (embedLines.x is a line, but embedLines.x.lines contains the text in a single line - in other words: it's not a line)

  1. … 1 more file in changeset.
code layout changes…
code layout changes

Renamed oldChatItem.embed to oldChatItem.isEmbeded to better reflect what it's meant to say.

  1. … 1 more file in changeset.
code optimisation…
code optimisation

Removed the redundant boolean: EnhancedTooltip.hasEmbed and replaced it with references to EnhTT.embedLines.

  1. … 1 more file in changeset.
improved performance for embeded tooltips…
improved performance for embeded tooltips

Improved handling and rendering of embeded tooltip lines especially for colored lines. Usage of AddLine() was improved to do displaying and coloring of a single line in one step instead of adding the line first and change its color afterwards. Also changed the way embedLines is being reset (nolonger needs to iterate over all entries) and is being iterated over (use the faster ipairs() function instead of the slower but unnecessary pairs() one).

  1. … 1 more file in changeset.
tiny code improvement…
tiny code improvement

Changed the handling of EnhTT.currentItem to unset it to nil instead of "". That way some checks became unnecessary and could be removed.

  1. … 1 more file in changeset.
(fixes #1518) showing the popup window while holding down the specified popup key and left-clicking a chatlink works now properly.…
(fixes #1518) showing the popup window while holding down the specified popup key and left-clicking a chatlink works now properly.

doHyperlink() sets testPopup to false/true, depending on the pressed button and passes the argument to tooltipCall(). tooltipCall() on the other side does explicitly check that passed argument for true or nil and excludes false at all, which caused this bug. The new behaviour is to interpret the passed argument "forcePopup" as true, unless it's nil or false.

  1. … 1 more file in changeset.
code improvement…
code improvement

embedRender() was changed to use passed parameters instead of using the EnhTT-table. This fixes a design issue, which could lead to a bug that would display embeded data in the wrong gameTooltip.

  1. … 1 more file in changeset.
Fixes a bug in Informant, which caused wrong item names being displayed in the enhanced tooltip.…
Fixes a bug in Informant, which caused wrong item names being displayed in the enhanced tooltip.

This fix also changes the behaviour of Informant to display the localised item name based on the client's language rather than using the item name in a chatlink.

Informant hid the passed name value when breaking the itemlink leading to the wrong itemname being displayed (only recognizable when using user generated itemlinks or clicking an itemlink which was generated by a WoW client in another language).

  1. … 1 more file in changeset.
code optimisation…
code optimisation

Removed setting of EnhTTData.currentItem in doHyperlink() which never worked properly, since the itemSig was incorrect. If that part of the code would have worked, tooltipCall() would have never been called generated a proper tooltip which would have resulted in wrong or none EnhTT being displayed. Therefore this line of code was removed. By removing this line, the current behaviour of the code was not changed.

  1. … 1 more file in changeset.
(fixes #1483) updated the all string files for 4.0 and 4.2.…
(fixes #1483) updated the all string files for 4.0 and 4.2.

This fixes a bug reported in #1483 for the French localisation.

    • -10
    • +36
    ./beancounter/BeanCounterStrings.lua
  1. … 6 more files in changeset.